Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation migration messaging #733

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

JacobMGEvans
Copy link
Contributor

Improving visualization of the deprecation messages between serious and warnings with emojis. This also improves their delineation between messages.

Related to #681 improvements.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2022

🦋 Changeset detected

Latest commit: 1552530

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2090944062/npm-package-wrangler-733

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/733/npm-package-wrangler-733

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2090944062/npm-package-wrangler-733 dev path/to/script.js

@JacobMGEvans
Copy link
Contributor Author

JacobMGEvans commented Mar 30, 2022

I'm thinking an example-migration-app would be good for inline documentation and something we can test Wrangler2 against for legacy workers with complex TOML files.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better already. I made two suggestions that are open for discussion.

packages/wrangler/src/config/validation-helpers.ts Outdated Show resolved Hide resolved
packages/wrangler/src/index.tsx Outdated Show resolved Hide resolved
@JacobMGEvans JacobMGEvans force-pushed the jacobmgevans/deprecation-migration-messaging branch from 12d685c to c763920 Compare March 31, 2022 15:03
…erious and warnings with emojis. This also improves their delineation between messages.
@JacobMGEvans JacobMGEvans force-pushed the jacobmgevans/deprecation-migration-messaging branch from c763920 to 02617f4 Compare April 4, 2022 15:23
@JacobMGEvans JacobMGEvans force-pushed the jacobmgevans/deprecation-migration-messaging branch from 02617f4 to 1552530 Compare April 4, 2022 15:40
@petebacondarwin petebacondarwin merged commit 91873e4 into main Apr 4, 2022
@petebacondarwin petebacondarwin deleted the jacobmgevans/deprecation-migration-messaging branch April 4, 2022 16:33
@github-actions github-actions bot mentioned this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants