feat: Non-interactive mode #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
requested review from
petebacondarwin,
geelen,
caass and
JacobMGEvans
🦋 Changeset detectedLatest commit: 1cdc470 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2048067903/npm-package-wrangler-712You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/712/npm-package-wrangler-712Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2048067903/npm-package-wrangler-712 dev path/to/script.js |
Closed
threepointone
force-pushed
the
local-mode-tests
branch
2 times, most recently
from
f0d93ea
to
d11662b
Compare
Continuing the work from #325, this detects when wrangler is running inside an environment where "raw" mode is not available on stdin, and disables the features for hot keys and the shortcut bar. This also adds stubs for testing local mode functionality in `local-mode-tests`, and deletes the previous hacky `dev2.test.tsx`. Fixes #322
threepointone
force-pushed
the
local-mode-tests
branch
from
d11662b
to
1cdc470
Compare
petebacondarwin
approved these changes
Mar 28, 2022
| "description": "", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "npx jest --forceExit" |
There was a problem hiding this comment.
Is forceExit still needed here?
There was a problem hiding this comment.
Unfortunately yes. Something about our script that hangs on windows even when we try to kill it. I'll investigate that separately when making a first class api for calling this in tests.
Merged
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
* Add Content-Length and FixedLengthStream to R2 get response Before this, we would see that the following code wouldn't work: ``` const res = await env.BUCKET.get(name); await env.BUCKET.put(name, res!.body); ``` As it would throw: TypeError: Provided readable stream must have a known length (request/response body or readable half of FixedLengthStream) * Test fixed length R2 get responses --------- Co-authored-by: bcoll <[email protected]>
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
* Add Content-Length and FixedLengthStream to R2 get response Before this, we would see that the following code wouldn't work: ``` const res = await env.BUCKET.get(name); await env.BUCKET.put(name, res!.body); ``` As it would throw: TypeError: Provided readable stream must have a known length (request/response body or readable half of FixedLengthStream) * Test fixed length R2 get responses --------- Co-authored-by: bcoll <[email protected]>
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
* Add Content-Length and FixedLengthStream to R2 get response Before this, we would see that the following code wouldn't work: ``` const res = await env.BUCKET.get(name); await env.BUCKET.put(name, res!.body); ``` As it would throw: TypeError: Provided readable stream must have a known length (request/response body or readable half of FixedLengthStream) * Test fixed length R2 get responses --------- Co-authored-by: bcoll <[email protected]>
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
* Add Content-Length and FixedLengthStream to R2 get response Before this, we would see that the following code wouldn't work: ``` const res = await env.BUCKET.get(name); await env.BUCKET.put(name, res!.body); ``` As it would throw: TypeError: Provided readable stream must have a known length (request/response body or readable half of FixedLengthStream) * Test fixed length R2 get responses --------- Co-authored-by: bcoll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work from #325, this detects when wrangler is running inside an environment where "raw" mode is not available on stdin, and disables the features for hot keys and the shortcut bar. This also adds stubs for testing local mode functionality in
local-mode-tests, and deletes the previous hackydev2.test.tsx.Fixes #322