fix: add warning about wrangler dev with remote Durable Objects
#687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b9bb4c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2035829987/npm-package-wrangler-687You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/687/npm-package-wrangler-687Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2035829987/npm-package-wrangler-687 dev path/to/script.js |
petebacondarwin
force-pushed
the
warn-on-durable-objects-in-different-script
branch
from
45eba66
to
c66d1d7
Compare
Durable Objects that are being bound by `script_name` will not be isolated from the live data during development with `wrangler dev`. This change simply warns the developer about this, so that they can back out before accidentally changing live data. Fixes cloudflare#319
petebacondarwin
force-pushed
the
warn-on-durable-objects-in-different-script
branch
from
c66d1d7
to
b9bb4c9
Compare
petebacondarwin
commented
Mar 24, 2022
|
We should also follow up internally and ask for an "environment" that we can pass to the binding, so one could, for example, bind to a staging/non prod environment during dev |
threepointone
approved these changes
Mar 25, 2022
Merged
|
Thanks @petebacondarwin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Durable Objects that are being bound by
script_namewill not be isolated from thelive data during development with
wrangler dev.This change simply warns the developer about this, so that they can back out before
accidentally changing live data.
Fixes #319