Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if the user is trying to implement DO's in a service worker #640

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

caass
Copy link
Contributor

@caass caass commented Mar 18, 2022

I think...this...is good..?

Continuation of #634

Closes #635

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2022

🦋 Changeset detected

Latest commit: c2aca9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2016752566/npm-package-wrangler-640

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/640/npm-package-wrangler-640

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2016752566/npm-package-wrangler-640 dev path/to/script.js

@caass caass marked this pull request as draft March 18, 2022 14:45
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

packages/wrangler/src/entry.ts Outdated Show resolved Hide resolved
@caass caass marked this pull request as ready for review March 21, 2022 14:35
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the extensive tests! This looks great, let's ship it.

@threepointone threepointone merged commit 2a2d50c into main Mar 22, 2022
@threepointone threepointone deleted the do-service-worker branch March 22, 2022 03:38
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should error when a user tries to implement a durable object in a worker using the service-worker format
3 participants