-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --yes
flag to wrangler init
#448
Conversation
🦋 Changeset detectedLatest commit: f0d304d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wrangler prerelease is available for testing: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1831806780/wrangler |
e08f391
to
dc7f62a
Compare
I was thinking about this recently and I think that, while having a For example you might have |
Could do, but let's not do it just yet, let's add more flags if people ask for it. |
Perhaps |
Thing is, if people wanted customisation, they simply wouldn't use -y, and it would be easier to do the steps. (An optimisation that we can do, is bunch up the npm install commands for the very end. In a future PR.) |
I would say it is pretty common convention. |
dc7f62a
to
16778f8
Compare
packages/wrangler/src/index.tsx
Outdated
describe: | ||
"Skip confirmation prompt, automatic yes to prompts; assume 'yes' as answer to all prompts and run non-interactively.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs bikeshedding but is non-blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just way too long, let's keep it short and bikeshed. Maybe 'Answer "yes" to any prompts.'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't answer yes for clobbering existing wrangler projects, I am fine with that message though.
'Answer "yes" to any prompts for new projects.' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentatively approving with one nit, ship it.
…nteractively. - flag can be used with `--yes` or `--y`
16778f8
to
f0d304d
Compare
Add
--yes
with alias--y
flag as automatic answer to all prompts and runwrangler init
non-interactively.generated during setup:
resolves #446