Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish: package.json tweaks #403

Merged
merged 1 commit into from
Feb 9, 2022
Merged

polish: package.json tweaks #403

merged 1 commit into from
Feb 9, 2022

Conversation

JacobMGEvans
Copy link
Contributor

@JacobMGEvans JacobMGEvans commented Feb 6, 2022

To get wrangler init projects up and running with good ergonomics for deploying and development,
added default scripts "start" & "deploy" with assumed TS or JS files in generated ./src/index.
The name property is now derived from user input on init <name> or parent directory if no input is provided.

partial #399

@JacobMGEvans JacobMGEvans added the polish Small improvements to the experience label Feb 6, 2022
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2022

🦋 Changeset detected

Latest commit: f662485

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2022

wrangler prerelease is available for testing:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1815086745/wrangler

packages/wrangler/src/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset

packages/wrangler/src/index.tsx Outdated Show resolved Hide resolved
packages/wrangler/src/index.tsx Outdated Show resolved Hide resolved
packages/wrangler/src/index.tsx Outdated Show resolved Hide resolved
packages/wrangler/src/index.tsx Outdated Show resolved Hide resolved
@JacobMGEvans JacobMGEvans changed the title polish: Added scripts to package.json polish: Added scripts to package.json & autogenerated name value Feb 8, 2022
@JacobMGEvans JacobMGEvans changed the title polish: Added scripts to package.json & autogenerated name value polish: package.json tweaks Feb 8, 2022
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @JacobMGEvans - thanks for iterating on this. Just a few more tweaks from my side.

.changeset/orange-hats-yell.md Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/index.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/index.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/index.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/index.tsx Outdated Show resolved Hide resolved
packages/wrangler/src/index.tsx Show resolved Hide resolved
packages/wrangler/src/index.tsx Outdated Show resolved Hide resolved
packages/wrangler/src/index.tsx Outdated Show resolved Hide resolved
To get wrangler init projects up and running with good ergonomics for deploying and development,
added default scripts "start" & "deploy" with assumed TS or JS files in generated ./src/index
Provide messages of how to utilize the scripts or npx wrangler based on if the scripts were generated.
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks.

@JacobMGEvans JacobMGEvans merged commit f9fef8f into main Feb 9, 2022
@JacobMGEvans JacobMGEvans deleted the polish/package-scripts branch February 9, 2022 14:05
@github-actions github-actions bot mentioned this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Small improvements to the experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants