Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages Plugins #349

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Pages Plugins #349

merged 2 commits into from
Apr 21, 2022

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Jan 31, 2022

This allows people to compile Plugins for Pages Functions. A compiled plugin is a factory for something incredibly similar to a compiled Pages Functions worker, but with just a couple of minor tweaks.

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2022

🦋 Changeset detected

Latest commit: 3185aaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@threepointone
Copy link
Contributor

Is this urgent? Could we please table this till I'm back? Thank you!

cc @geelen

@GregBrimble GregBrimble force-pushed the pages-plugins branch 2 times, most recently from c91fca4 to f346657 Compare February 3, 2022 22:26
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2200825764/npm-package-wrangler-349

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/349/npm-package-wrangler-349

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2200825764/npm-package-wrangler-349 dev path/to/script.js

@GregBrimble GregBrimble force-pushed the pages-plugins branch 5 times, most recently from 0252ee9 to d152684 Compare February 7, 2022 14:14
@petebacondarwin petebacondarwin added the pages Relating to Pages label Feb 28, 2022
Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, looks good, few small comments.

Also wonder if we should just have a plugins subcommand instead. Then we can have wrangler pages plugins build and even things like wrangler pages plugins install

@GregBrimble GregBrimble merged commit 9d04a68 into main Apr 21, 2022
@GregBrimble GregBrimble deleted the pages-plugins branch April 21, 2022 13:59
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants