feat: enhance wrangler init
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 43ebbec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
force-pushed
the
enhance-wrangler-init
branch
2 times, most recently
from
fa750f9
to
88395bb
Compare
|
Not bad, it didn't get that much slower. |
threepointone
force-pushed
the
enhance-wrangler-init
branch
from
88395bb
to
0792eea
Compare
petebacondarwin
requested changes
Jan 25, 2022
There was a problem hiding this comment.
Nice work @threepointone! I love the new test helper.
If you can resolve all my questions then I will happily mark this as approved.
threepointone
force-pushed
the
enhance-wrangler-init
branch
from
0792eea
to
0707b7e
Compare
|
Answered, modified, parried. Looks good? |
petebacondarwin
approved these changes
Jan 26, 2022
threepointone
force-pushed
the
enhance-wrangler-init
branch
2 times, most recently
from
a5afdae
to
d8fc913
Compare
This PR adds some enhancements/fixes to the `wrangler init` command. - doesn't overwrite `wrangler.toml` if it already exists - installs `wrangler` when creating `package.json` - offers to install `wrangler` into `package.json` even if `package.json` already exists - offers to install `@cloudflare/workers-types` even if `tsconfig.json` already exists - pipes stdio back to the terminal so there's feedback when it's installing npm packages This does have the side effect of making our tests a _little_ slower. I added `--prefer-offline` to the `npm install` calls to make this a shade quicker, but I can't figure out a good way of mocking these. I'll think about it some more later. We should work on making the installs themselves quicker (re: #66) This PR also fixes an issue with our tests: `runWrangler()` would catch thrown errors, and if we didn't manually verify the error, tests would pass. Instead, it now throws correctly, and I modified all the tests to assert on thrown errors. It seems like a lot, but it was just mechanical rewriting.
threepointone
force-pushed
the
enhance-wrangler-init
branch
from
d8fc913
to
43ebbec
Compare
Merged
This was referenced Nov 23, 2023
This was referenced Dec 1, 2023
This was referenced Jan 9, 2024
This was referenced Jan 17, 2024
This was referenced Jan 25, 2024
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some enhancements/fixes to the
wrangler initcommand.wrangler.tomlif it already existswranglerwhen creatingpackage.jsonwranglerintopackage.jsoneven ifpackage.jsonalready exists@cloudflare/workers-typeseven iftsconfig.jsonalready existsThis does have the side effect of making our tests a little slower. I added
--prefer-offlineto thenpm installcalls to make this a shade quicker, but I can't figure out a good way of mocking these. I'll think about it some more later. We should work on making the installs themselves quicker (re: #66)This PR also fixes an issue with our tests:
runWrangler()would catch thrown errors, and if we didn't manually verify the error, tests would pass. Instead, it now throws correctly, and I modified all the tests to assert on thrown errors. It seems like a lot, but it was just mechanical rewriting.