feature: add more types that get logged via console methods
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aff14b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
commented
Jan 25, 2022
packages/wrangler/src/inspect.ts
Outdated
| @@ -539,5 +575,7 @@ function logConsoleMessage(evt: Protocol.Runtime.ConsoleAPICalledEvent): void { | |||
| } | |||
| } | |||
|
|
|||
| console[evt.type](...args); | |||
| const method = mapConsoleAPIMessageTypeToConsoleMethod[evt.type]; | |||
| //@ts-expect-error I dunno how to make this type pass lol | |||
There was a problem hiding this comment.
You need to exclude the constructor from the list of keys:
export const mapConsoleAPIMessageTypeToConsoleMethod: {
[key in Protocol.Runtime.ConsoleAPICalledEvent["type"]]: Exclude<
keyof Console,
"Console"
>;But then TS complains that args must be a tuple or be passed to a rest argument.
We can work around that by using apply() (telling eslint not to stress):
// eslint-disable-next-line prefer-spread
console[method].apply(console, args);This PR adds more special logic for some data types that get logged via `console` methods. Types like `Promise`, `Date`, `WeakMaps`, and some more, now get logged correctly (or at least, better than they used to). This PR also fixes a sinister bug - the `type` of the `ConsoleAPICalled` events don't match 1:1 with actual console methods (eg: `console.warn` message type is `warning`). This PR adds a mapping between those types and method names. Some methods don't seem to have a message type, I'm not sure why, but we'll get to them later.
threepointone
force-pushed
the
feat-console-types
branch
from
6ce866d
to
aff14b6
Compare
|
Working on tests right now, in a separate PR, based on the description here #188 (comment). Going to be a bit involved, don't want to block this bugfix here. |
petebacondarwin
approved these changes
Jan 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more special logic for some data types that get logged via
consolemethods. Types likePromise,Date,WeakMaps, and some more, now get logged correctly (or at least, better than they used to).This PR also fixes a sinister bug - the
typeof theConsoleAPICalledevents don't match 1:1 with actual console methods (eg:console.warnmessage type iswarning). This PR adds a mapping between those types and method names. Some methods don't seem to have a message type, I'm not sure why, but we'll get to them later.