fix: warn if the site.entry-point configuration is found during publishing
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6be9e85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
force-pushed
the
deprecate-sites-entry-point
branch
from
0b928c6
to
80833a2
Compare
|
This should probably have a deprecation error, unless we already throw if we don't find an entry point? |
|
Currently we throw if there is neither a command line script nor a configured |
threepointone
approved these changes
Jan 24, 2022
|
I realised that the current flow might be a bit weird for those who have not set up other means for specifying entry-points. They will only receive an error "missing main file". 😢 |
petebacondarwin
force-pushed
the
deprecate-sites-entry-point
branch
from
80833a2
to
c1e4d12
Compare
petebacondarwin
force-pushed
the
deprecate-sites-entry-point
branch
from
c1e4d12
to
078523c
Compare
threepointone
approved these changes
Jan 25, 2022
petebacondarwin
force-pushed
the
deprecate-sites-entry-point
branch
2 times, most recently
from
fe20aed
to
cf70bd0
Compare
…lishing Also updates the message and adds a test for the error when there is no entry-point specified. Fixes cloudflare#282
petebacondarwin
force-pushed
the
deprecate-sites-entry-point
branch
from
cf70bd0
to
6be9e85
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it enough to log a warning? Or should we throw a
new DeprecationError()?Fixes #282