Publishing site assets include/exclude support #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26b91d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
force-pushed
the
sites-validation
branch
from
35ac4c0
to
d0f4a3e
Compare
GregBrimble
reviewed
Jan 20, 2022
petebacondarwin
force-pushed
the
sites-validation
branch
3 times, most recently
from
4d02710
to
88b57c4
Compare
The `fetchInternal()` function assumes that the request is a GET if none is specified. This change brings the `mockFetchInternal()` function in line with this.
The previous output was passing an array of objects to console.log, which ended up showing something like ``` [Object object] [Object object] ... ``` Now the result is JSON stringified before being sent to the console. The tests have been fixed to check this too.
petebacondarwin
force-pushed
the
sites-validation
branch
from
88b57c4
to
28909ff
Compare
threepointone
approved these changes
Jan 24, 2022
Previously we were checking whether the base64 encoded size of an asset was too large (>25MiB). But base64 takes up more space than a normal file, so this was too aggressive.
petebacondarwin
force-pushed
the
sites-validation
branch
from
28909ff
to
26b91d4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for include/exclude options when publishing site assets.
It also fixes the output of
kv:key list.There are also a few refactorings to prepare the way for this.
QUESTION: Do we want to add the
site-includeandsite-excludeCLI args to publish? I like the consistency that creates with our move toward CLI oriented development (not relying upon config) but since Sites assets are somewhat legacy, we may not want to invest in that public API? cc @threepointone