Fix silent failure when browser open doesn't work

[jkriss]

The solution in #211 doesn't work, because the error is thrown by the child process returned by the open function, not by the open itself.

Tested with GitHub Codespaces.

[changeset-bot]

🦋 Changeset detected

Latest commit: 50b4aa4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[petebacondarwin]

LGTM.

[threepointone]

This is looking good! Please add a changeset, as per the instructions. Also, run npm run prettify at the root of the package to pass the build error.

[threepointone]

This looks good, thank you very much for your PR!

[threepointone]

You can try the fix by using wrangler@alpha. We'll eventually do a beta release, probably early next week.

[jkriss]

Nice, my fix works with wrangler@alpha. I did, however, get this error with alpha:

Cannot find package '@miniflare/core' imported from /workspaces/finite.photos/node_modules/wrangler/wrangler-dist/cli.js Running npm i -D @miniflare/core fixed it.

Looks like that came in with #186 , but the @miniflare/core package wasn't added to package.json.

[threepointone]

Thanks for the catch! This might be because of #264. I'll fix this tomorrow.

[petebacondarwin]

miniflare/core is a dependency of miniflare, so it should not need to be directly added to the wrangler package.json nor your own project. I just updated a project to wrangler@alpha and all these deps were there. I wonder if your node_modules just got a bit corrupted when you updated to alpha?

[jkriss]

Yep, sure enough. Sorry for the false alarm!