fix: fix dev and publish
#262
Conversation
🦋 Changeset detectedLatest commit: 0091b94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We introduced some bugs in recent PRs: - In #196, we broke being able to pass an entrypoint directly to the cli. In this PR, I just reverted that fix. I'll reopen #78 and we'll tackle it again later. (cc @jgentes) - In #215, we broke being able to publish a script by just passing `--latest` or `--compatibility-data` in the cli. This PR fixes that by reading the correct argument when choosing whether to publish. - In #247, we broke how we made requests by passing headers to requests. This PR reverts the changes made in `cfetch/internal.ts`. (cc @petebacondarwin) - In #244, we broke `dev` and it would immediately crash. This PR fixes the reference in `dev.tsx` that was breaking. (cc @petebacondarwin)
threepointone
force-pushed
the
fix-dev
branch
from
8f0223a
to
0091b94
Compare
|
I think that this one:
|
|
Can you explain why this is breaking?
|
|
I dunno, I debugged by bisecting, reverted that specific change and it prevented |
In cloudflare#262 some of the strict null fixes were removed to resolve a regression. This refactor re-applies these fixes in a way that avoids that problem.
In cloudflare#262 some of the strict null fixes were removed to resolve a regression. This refactor re-applies these fixes in a way that avoids that problem.
In #262 some of the strict null fixes were removed to resolve a regression. This refactor re-applies these fixes in a way that avoids that problem.
We introduced some bugs in recent PRs:
--compatibility-date,--compatibility-flags,--latestcli arguments todevandpublish#215, we broke being able to publish a script by just passing--latestor--compatibility-datain the cli. This PR fixes that by reading the correct argument when choosing whether to publish.cfetch/internal.ts. (cc @petebacondarwin)devandpublishcommands #244, we brokedevand it would immediately crash. This PR fixes the reference indev.tsxthat was breaking. (cc @petebacondarwin)