Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor proxy code to pass strict-null checks #248

Merged

Conversation

petebacondarwin
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2022

🦋 Changeset detected

Latest commit: 15d7a40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer inlined abstractions to prevent jumping around to understand the code, but ok.

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset!

@petebacondarwin
Copy link
Contributor Author

I prefer inlined abstractions to prevent jumping around to understand the code, but ok.

Yeah, I know what you mean.

There is also the converse problem where the inlined function is so big that it is difficult to understand the calling code: i.e. it is difficult to see and understand the calling code in one go, since the rest of the code is off the screen.

In this case, it felt that the benefits to the calling code outweighed the cost of not having the function inline. (Cmd-Click is my friend in these cases).

@petebacondarwin petebacondarwin merged commit 5806932 into cloudflare:main Jan 18, 2022
@petebacondarwin petebacondarwin deleted the strict-null-checks-proxy branch January 18, 2022 14:34
@github-actions github-actions bot mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants