-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor proxy code to pass strict-null checks #248
Refactor proxy code to pass strict-null checks #248
Conversation
🦋 Changeset detectedLatest commit: 15d7a40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer inlined abstractions to prevent jumping around to understand the code, but ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changeset!
Yeah, I know what you mean. There is also the converse problem where the inlined function is so big that it is difficult to understand the calling code: i.e. it is difficult to see and understand the calling code in one go, since the rest of the code is off the screen. In this case, it felt that the benefits to the calling code outweighed the cost of not having the function inline. ( |
7522fe3
to
ce2bd41
Compare
ce2bd41
to
15d7a40
Compare
No description provided.