Upgrade miniflare to 2.0.0 🎉
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watching `all` events without `ignoreInitial` set to `true` means `chokidar` will call the callback immediately. This caused functions to be built twice, and Miniflare to be `reload`ed immediately after startup.
Instead of using a `scriptReady` boolean, this now uses a deferred `Promise`, so the event loop isn't blocked. This is `await`ed before constructing the `new Miniflare`, as this will asynchronously kick off loading the script.
Subsequent Pages Functions worker builds due to file changes were not replacing `__FALLBACK_SERVICE_FETCH__` leading to `ReferenceError`s. This change switches to using `esbuild`'s built-in `define` option, instead of `esbuild-plugin-replace`, removing an additional dependency.
🦋 Changeset detectedLatest commit: 41d6df0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GregBrimble
reviewed
Jan 8, 2022
threepointone
approved these changes
Jan 8, 2022
GregBrimble
approved these changes
Jan 8, 2022
GregBrimble
reviewed
Jan 8, 2022
|
Landing this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋 This PR upgrades
miniflareto version2.0.0. There were only a couple changes since2.0.0-rc.5, mostly around makingfetchbehave more like Cloudflare's. See the bottom of the changelog.I've also made another few minor tweaks to
pages dev:allevents withoutignoreInitialset totruemeanschokidarcalls the callback immediately. This caused functions to be built twice, and Miniflare to bereloaded immediately after startup.scriptReadyboolean, this now uses a deferredPromise, so the event loop isn't blocked. This is nowawaited before constructing thenew Miniflare, as this is what asynchronously kicks off loading the script. It looks like this wasn't doing anything before though, sincescriptReadywas initialised totrue.ReferenceError: __FALLBACK_SERVICE_FETCH__ is not definedon watch update withpages dev: subsequent Pages Functions worker builds due to file changes were not replacing__FALLBACK_SERVICE_FETCH__leading toReferenceErrors (I think this is a bug inesbuild-plugin-replace). This change switches to usingesbuild's built-indefineoption, instead ofesbuild-plugin-replace, removing an additional dependency.cc @GregBrimble