Ignore non-JS files when compiling Pages Functions #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cade6c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Sunil Pai <[email protected]>
threepointone
approved these changes
Jan 7, 2022
Merged
| @@ -33,7 +33,7 @@ export async function generateConfigFromFileTree({ | |||
|
|
|||
| await forEachFile(baseDir, async (filepath) => { | |||
| const ext = path.extname(filepath); | |||
| if (/\.(mjs|js|ts)/.test(ext)) { | |||
| if (/^\.(mjs|js|ts|tsx|jsx)$/.test(ext)) { | |||
| // transform the code to ensure we're working with vanilla JS + ESM | |||
| const { code } = await transform(await fs.readFile(filepath, "utf-8"), { | |||
| loader: ext === ".ts" ? "ts" : "js", | |||
There was a problem hiding this comment.
oh hmm maybe you should do a check for .tsx here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
More strictly check file extensions when crawling the
/functionsdirectory to ensure we're only trying to include JS files.