rename --public as --experimental-public
#214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 758bb22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/wrangler/src/index.tsx
Outdated
| } | ||
|
|
||
| if (args.public) { | ||
| console.error( |
There was a problem hiding this comment.
Don't you want to throw here?
There was a problem hiding this comment.
yeah, I probably should.
This PR is a breaking change. We'll keep it as a patch release tho. We want to change the behaviour of `--public` to closer match Pages behaviour, and only really expose it in v2.1 (maybe even after that). This PR renames the field as `experimental-public`, and adds warnings. In a future PR we'll actually change the behaviour.
threepointone
force-pushed
the
experimental-public
branch
from
900bc9a
to
758bb22
Compare
petebacondarwin
approved these changes
Jan 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a breaking change. We'll keep it as a patch release tho.
We want to change the behaviour of
--publicto closer match Pages behaviour, and only really expose it in v2.1 (maybe even after that).This PR renames the field as
experimental-public, and adds warnings. In a future PR we'll actually change the behaviour.