Remove explicit any types from the codebase
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes all use of `any` from the code and updates the `no-explicit-any` eslint rule to be an error.
🦋 Changeset detectedLatest commit: 479f3ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
approved these changes
Jan 7, 2022
|
|
||
| type EventContext<Env, P extends string, Data> = { | ||
| request: Request; | ||
| waitUntil: (promise: Promise<any>) => void; | ||
| waitUntil: (promise: Promise<unknown>) => void; |
There was a problem hiding this comment.
I don't think waitUntil can return anything, so this should probably be void
Suggested change
| waitUntil: (promise: Promise<unknown>) => void; | |
| waitUntil: (promise: Promise<void>) => void; |
There was a problem hiding this comment.
It doesn't do anything with the return, but I can still return something if I choose.
There was a problem hiding this comment.
waitUntil(Promise.resolve(5)) is totally valid.
GregBrimble
reviewed
Jan 7, 2022
| @@ -1,14 +1,12 @@ | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
|
|
|||
| import { match } from "path-to-regexp"; | |||
| import type { HTTPMethod } from "./routes"; | |||
|
|
|||
| /* TODO: Grab these from @cloudflare/workers-types instead */ | |||
There was a problem hiding this comment.
As I've said, I do hope to get rid of these entirely soon.
GregBrimble
approved these changes
Jan 7, 2022
threepointone
approved these changes
Jan 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes all use of
anyfrom the code and updates theno-explicit-anyeslint rule to be an error.Resolves #201