Further key-value tests and refactorings #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5ad907c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
force-pushed
the
kv-tests-3
branch
from
f998fad
to
e02f0be
Compare
packages/wrangler/package.json
Outdated
| @@ -116,5 +120,18 @@ | |||
| "setupFilesAfterEnv": [ | |||
| "<rootDir>/src/__tests__/jest.setup.ts" | |||
| ] | |||
| }, | |||
There was a problem hiding this comment.
this doesn't seem right, that's why we have esbuild-jest, to strip the types.
There was a problem hiding this comment.
Because of this: aelbore/esbuild-jest#57
petebacondarwin
force-pushed
the
kv-tests-3
branch
6 times, most recently
from
d04a03c
to
9cd63e6
Compare
petebacondarwin
force-pushed
the
kv-tests-3
branch
from
9cd63e6
to
5ad907c
Compare
|
Looking good to me. Read through both commits. I also noticed some improvements to naming conventions which is a nice ergonomic change too. |
|
sorry for the delay on reviewing this, promise I'll do so tomorrow |
threepointone
approved these changes
Jan 7, 2022
Well you can rename it back to cfetch if you like 😸 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for the details.
The refactoring of the cfetch stuff makes it possible to handle "cursors" for when lists come back in chunks.
Note that in order to use the module mocking (i.e.
mock('../cfetch/internal')) I created an "internal" module that gets mocked. The actual API that downstream callers access is just../cfetch- but these then wrap the internal one with extra behaviour.Note also that it is not allowed to have any TS type annotations in files that contain the string
ock(!! This is because theesbuild-jestplugin runs a Babel transform of files that contain that string, and it cannot handle TS annotations.