Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email from env & error messaging #1363

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Jun 28, 2022

Display email from process env in whoami and display better error when lacking permissions.

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2022

🦋 Changeset detected

Latest commit: 15ab880

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2577066073/npm-package-wrangler-1363

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1363/npm-package-wrangler-1363

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2577066073/npm-package-wrangler-1363 dev path/to/script.js

@JacobMGEvans
Copy link
Contributor

This was a fun rabbit hole lol

@JacobMGEvans JacobMGEvans added the bug Something that isn't working label Jun 28, 2022
@JacobMGEvans JacobMGEvans changed the title fix: display email from process env in whoami and display better erro… fix: email from env & error messaging Jun 28, 2022
@@ -21,6 +26,7 @@ describe("getUserInfo()", () => {

afterEach(() => {
process.env = ENV_COPY;
unsetAllMocks();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@petebacondarwin petebacondarwin merged commit b2c2c2b into cloudflare:main Jun 28, 2022
@petebacondarwin petebacondarwin deleted the whoami-fixes branch June 28, 2022 19:19
@github-actions github-actions bot mentioned this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants