Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure Response is mutable in Pages functions #1325

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

sidharthachatterjee
Copy link
Contributor

Fixes #1244

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2022

🦋 Changeset detected

Latest commit: df0f8b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sidharthachatterjee sidharthachatterjee added the pages Relating to Pages label Jun 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2542155192/npm-package-wrangler-1325

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1325/npm-package-wrangler-1325

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2542155192/npm-package-wrangler-1325 dev path/to/script.js

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some bike-shedding and typings nits.

@sidharthachatterjee sidharthachatterjee merged commit bcd066d into main Jun 22, 2022
@sidharthachatterjee sidharthachatterjee deleted the make-response-mutable branch June 22, 2022 12:19
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Pages next() headers mutable in local dev, but not in production
3 participants