Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kv:key binary puts/gets #1287

Merged
merged 9 commits into from
Jun 17, 2022
Merged

Conversation

f5io
Copy link
Contributor

@f5io f5io commented Jun 17, 2022

fixes #1254 and fixes #1273

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2022

🦋 Changeset detected

Latest commit: 8c5bff0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2515087957/npm-package-wrangler-1287

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1287/npm-package-wrangler-1287

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2515087957/npm-package-wrangler-1287 dev path/to/script.js

@f5io f5io marked this pull request as ready for review June 17, 2022 10:59
@f5io
Copy link
Contributor Author

f5io commented Jun 17, 2022

hi @threepointone, i believe this will resolve the issue around kv:key get. i have had to add a new spy to process.stdout.write for the tests to capture the raw output.

edit: it also includes the code that was reverted for the put.

@rozenmd
Copy link
Contributor

rozenmd commented Jun 17, 2022

Thanks so much for this @f5io !

I've confirmed round-trip md5 hashes match for wrangler1 -> wrangler2 (this PR) and wrangler2 (this PR) -> wrangler2 (this PR), just trying to work out if we can salvage any data we've written with older wrangler2 builds that were writing text instead of binary

Copy link
Contributor

@rozenmd rozenmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this - we'll make a follow-up PR that passes a --text flag (or similar) to kv:key get that lets folks utf-8 decode any binary data they may have uploaded with prior wrangler 2 versions

@rozenmd rozenmd merged commit 2072e27 into cloudflare:main Jun 17, 2022
@github-actions github-actions bot mentioned this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants