fix: support all git versions for wrangler init #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5ac7704 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2528900878/npm-package-wrangler-1265You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1265/npm-package-wrangler-1265Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2528900878/npm-package-wrangler-1265 dev path/to/script.js |
rozenmd
reviewed
Jun 15, 2022
petebacondarwin
force-pushed
the
git-init-2
branch
2 times, most recently
from
b377829
to
60a720b
Compare
If `git` does not support the `--initial-branch` argument then just fallback to the default initial branch name. We tried to be more clever about this but there are two many weird corner cases with different git versions on different architectures. Now we do our best, with recent versions of git, to ensure that the branch is called `main` but otherwise just make sure we don't crash. Fixes cloudflare#1228
petebacondarwin
force-pushed
the
git-init-2
branch
from
60a720b
to
5ac7704
Compare
petebacondarwin
changed the title
wrangler init
threepointone
approved these changes
Jun 20, 2022
rozenmd
approved these changes
Jun 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
gitdoes not support the--initial-branchargument then just fallback to the default initial branch name.We tried to be more clever about this but there are two many weird corner cases with different git versions on different architectures.
Now we do our best, with recent versions of git, to ensure that the branch is called
mainbut otherwise just make sure we don't crash.Fixes #1228