Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass localProtocol to miniflare for https server #1250

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Jun 14, 2022

Potential issue:

Chrome shows the page as https (not secure):
image

Closes #1247

@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2022

🦋 Changeset detected

Latest commit: 8f7922b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2493911464/npm-package-wrangler-1250

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1250/npm-package-wrangler-1250

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2493911464/npm-package-wrangler-1250 dev path/to/script.js

@rozenmd rozenmd marked this pull request as ready for review June 14, 2022 08:39
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome showing the warning is a known issue, not much we can do there, it's fine.

@rozenmd rozenmd merged commit e3278fa into main Jun 14, 2022
@rozenmd rozenmd deleted the https-in-local-mode branch June 14, 2022 08:48
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: local-protocol flag fails to start a https dev server in local mode
2 participants