Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support --experimental-public in local mode #1234

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

threepointone
Copy link
Contributor

--experimental-public is an abstraction over Workers Sites, and we can leverage miniflare's inbuilt support for Sites to serve assets in local mode.

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2022

🦋 Changeset detected

Latest commit: 7a0de52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2495768022/npm-package-wrangler-1234

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1234/npm-package-wrangler-1234

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2495768022/npm-package-wrangler-1234 dev path/to/script.js

@threepointone
Copy link
Contributor Author

threepointone commented Jun 12, 2022

The test failure on windows is odd, it appears to be stripping out \, I'll debug this later

image

EDIT: Fixed!

@threepointone
Copy link
Contributor Author

This needs some work done on it for tests to pass since #1241 landed (tho it'll still "work" otherwise.) Moving to wip.

@threepointone threepointone marked this pull request as draft June 14, 2022 09:16
@threepointone threepointone changed the title feat: support --experimental-public in local mode WIP feat: support --experimental-public in local mode Jun 14, 2022
@threepointone
Copy link
Contributor Author

Ok, I figured out the problem and sent a separate PR to fix it, included the test in that PR as well #1253, reopening this PR for review.

@threepointone threepointone marked this pull request as ready for review June 14, 2022 12:13
@threepointone threepointone changed the title WIP feat: support --experimental-public in local mode feat: support --experimental-public in local mode Jun 14, 2022
`--experimental-public` is an abstraction over Workers Sites, and we can leverage miniflare's inbuilt support for Sites to serve assets in local mode.
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the other PR fix, this looks good!

@threepointone threepointone merged commit 3e94bc6 into main Jun 14, 2022
@threepointone threepointone deleted the public-local-mode branch June 14, 2022 14:40
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants