-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support --experimental-public
in local mode
#1234
Conversation
🦋 Changeset detectedLatest commit: 7a0de52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2495768022/npm-package-wrangler-1234 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1234/npm-package-wrangler-1234 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2495768022/npm-package-wrangler-1234 dev path/to/script.js |
44ad535
to
0d90bff
Compare
cda8ca9
to
86c16d4
Compare
This needs some work done on it for tests to pass since #1241 landed (tho it'll still "work" otherwise.) Moving to wip. |
--experimental-public
in local mode--experimental-public
in local mode
86c16d4
to
f101422
Compare
Ok, I figured out the problem and sent a separate PR to fix it, included the test in that PR as well #1253, reopening this PR for review. |
--experimental-public
in local mode--experimental-public
in local mode
`--experimental-public` is an abstraction over Workers Sites, and we can leverage miniflare's inbuilt support for Sites to serve assets in local mode.
f101422
to
7a0de52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the other PR fix, this looks good!
--experimental-public
is an abstraction over Workers Sites, and we can leverage miniflare's inbuilt support for Sites to serve assets in local mode.