Skip to content

Reload server on config changes #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Reload server on config changes #1216

merged 2 commits into from
Jun 13, 2022

Conversation

JacobMGEvans
Copy link
Contributor

@JacobMGEvans JacobMGEvans commented Jun 9, 2022

When making changes to the configuration file, the development server will restart. Currently bindings is passed into the server to be refreshed.

#439

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2022

🦋 Changeset detected

Latest commit: aaa4c9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2491585053/npm-package-wrangler-1216

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1216/npm-package-wrangler-1216

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2491585053/npm-package-wrangler-1216 dev path/to/script.js

@JacobMGEvans JacobMGEvans force-pushed the reload-dev-config-change branch 2 times, most recently from 5df7c03 to 0c0c006 Compare June 9, 2022 17:26
@threepointone
Copy link
Contributor

The checks were running for close to 3 hours so I cancelled them

@JacobMGEvans
Copy link
Contributor Author

JacobMGEvans commented Jun 10, 2022

The checks were running for close to 3 hours so I cancelled them

Yeah I tried restarting them a few times throughout the day... I don't know what is going on. They are running locally fine.

Edit: Guess that is why the only test finishing is the MacOS one lol

@threepointone
Copy link
Contributor

Keep an eye on it the next time you do a push and stop it if it's going on for too long, or else we'll run out the free minutes we're allocated.

@JacobMGEvans JacobMGEvans force-pushed the reload-dev-config-change branch 6 times, most recently from 3318a63 to e8230d0 Compare June 10, 2022 21:50
@JacobMGEvans JacobMGEvans marked this pull request as draft June 10, 2022 22:07
@JacobMGEvans JacobMGEvans force-pushed the reload-dev-config-change branch from e8230d0 to 4adb6d4 Compare June 13, 2022 21:12
@JacobMGEvans JacobMGEvans marked this pull request as ready for review June 13, 2022 21:30
@JacobMGEvans JacobMGEvans requested a review from caass June 13, 2022 21:30
@JacobMGEvans JacobMGEvans assigned rozenmd and unassigned rozenmd Jun 13, 2022
@JacobMGEvans JacobMGEvans requested a review from rozenmd June 13, 2022 21:30
@JacobMGEvans JacobMGEvans force-pushed the reload-dev-config-change branch from 4adb6d4 to ca20d6e Compare June 13, 2022 21:31
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! dropped some nits, but approving anyway

@JacobMGEvans JacobMGEvans force-pushed the reload-dev-config-change branch from ca20d6e to d3264ea Compare June 13, 2022 22:28
…revent repeated logging and function calls.
@JacobMGEvans JacobMGEvans force-pushed the reload-dev-config-change branch from d3264ea to aaa4c9d Compare June 13, 2022 22:32
@JacobMGEvans JacobMGEvans merged commit 4eb70f9 into main Jun 13, 2022
@JacobMGEvans JacobMGEvans deleted the reload-dev-config-change branch June 13, 2022 22:40
@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants