-
Notifications
You must be signed in to change notification settings - Fork 856
Reload server on config changes #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: aaa4c9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2491585053/npm-package-wrangler-1216 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1216/npm-package-wrangler-1216 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2491585053/npm-package-wrangler-1216 dev path/to/script.js |
5df7c03
to
0c0c006
Compare
The checks were running for close to 3 hours so I cancelled them |
Yeah I tried restarting them a few times throughout the day... I don't know what is going on. They are running locally fine. Edit: Guess that is why the only test finishing is the MacOS one lol |
Keep an eye on it the next time you do a push and stop it if it's going on for too long, or else we'll run out the free minutes we're allocated. |
3318a63
to
e8230d0
Compare
e8230d0
to
4adb6d4
Compare
4adb6d4
to
ca20d6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! dropped some nits, but approving anyway
ca20d6e
to
d3264ea
Compare
…revent repeated logging and function calls.
d3264ea
to
aaa4c9d
Compare
When making changes to the configuration file, the development server will restart. Currently
bindings
is passed into the server to be refreshed.#439