fix: pass routes to dev session
#1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 34b64b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2576019442/npm-package-wrangler-1213You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1213/npm-package-wrangler-1213Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2576019442/npm-package-wrangler-1213 dev path/to/script.js |
|
This has problems when there are multiple hosts in the routes, and when different zone_name/zone_id's are provided. Need to work on this some more, moving to draft. |
threepointone
changed the title
routes to dev sessionroutes to dev session
threepointone
force-pushed
the
dev-routes
branch
from
9d9d550 to
a2177cf
Compare
We can pass routes when creating a `dev` session. The effect of this is when you visit a path that _doesn't_ match the given routes, then it instead does a fetch from the deployed worker on that path (if any). We were previously passing `*/*`, i.e, matching _all_ routes in dev; this fix now passes configured routes instead.
threepointone
force-pushed
the
dev-routes
branch
from
a2177cf to
34b64b0
Compare
|
Ok, I've tested that this doesn't break if you pass multiple hosts in routes to dev. This looks ready for review. |
threepointone
changed the title
routes to dev sessionroutes to dev session
rozenmd
approved these changes
Jun 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can pass routes when creating a
devsession. The effect of this is when you visit a path that doesn't match the given routes, then it instead does a fetch from the deployed worker on that path (if any). We were previously passing*/*, i.e, matching all routes in dev; this fix now passes configured routes instead. Based on #1055