-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deltas for 'wrangler pages publish' #1210
Conversation
🦋 Changeset detectedLatest commit: 2acaf2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1347c67
to
0a57051
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2476307750/npm-package-wrangler-1210 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1210/npm-package-wrangler-1210 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2476307750/npm-package-wrangler-1210 dev path/to/script.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Let's ensure the new API is up before we get this in. Thank you for the refactoring as well. That'll be helpful for later.
Fantastic!! We may consider tweaking |
389b48f
to
a7ca0b5
Compare
We can definitely do this if it's a commonly seen problem (or at the very least, we can provide more obvious feedback that an upload is actually happening). I'll keep an eye on issues. If you routinely see this, file one yourself. Otherwise, I'll wait to see if anyone else creates one. |
a7ca0b5
to
31355da
Compare
31355da
to
2acaf2d
Compare
Waiting on an internal thing to be released, but once that's out, this PR will be ready to go.It's out!feat: Upload the delta for
wrangler pages publish
We now keep track of the files that make up each deployment and intelligently only upload the files that we haven't seen. This means that similar subsequent deployments should only need to upload a minority of files and this will hopefully make uploads even faster.
The only bit that has changed is this: https://github.com/cloudflare/wrangler2/pull/1210/files#diff-671053f3ecffd0e36229ae8b3c6090a2becd125b2c3247a41de85836dca29884R1063-R1078
The rest is just pulling out the upload logic for future re-use.