fix: improve error message when CF API responds with an error #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5b67d2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2392812815/npm-package-wrangler-1122You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1122/npm-package-wrangler-1122Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2392812815/npm-package-wrangler-1122 dev path/to/script.js |
For example if you have an invalid CF_API_TOKEN and try running `wrangler whoami` you now get the additional `6111` error information: ``` ✘ [ERROR] A request to the Cloudflare API (/user) failed. Invalid request headers [code: 6003] - Invalid format for Authorization header [code: 6111] ```
petebacondarwin
force-pushed
the
not-a-bad-response
branch
from
fe48ac6 to
5b67d2d
Compare
JacobMGEvans
approved these changes
May 27, 2022
petebacondarwin
commented
May 27, 2022
| @@ -2754,7 +2754,7 @@ export async function main(argv: string[]): Promise<void> { | |||
| e.notes.push({ | |||
| text: "\nIf you think this is a bug, please open an issue at: https://github.com/cloudflare/wrangler2/issues/new", | |||
| }); | |||
| logger.error(formatMessage(e)); | |||
| logger.log(formatMessage(e)); | |||
There was a problem hiding this comment.
Using .log() here because the message already has an ERROR prefix, so we don't want .error() to add it again.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the current message confusing. The response is not bad it is a valid response saying that the request failed.