Fix incorrect extension extraction from file paths #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 00e06e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2350676635/npm-package-wrangler-1045You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1045/npm-package-wrangler-1045Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2350676635/npm-package-wrangler-1045 dev path/to/script.js |
jrf0110
force-pushed
the
1029-folders-periods
branch
from
d679919 to
fd1a5f8
Compare
jrf0110
force-pushed
the
1029-folders-periods
branch
from
fd1a5f8 to
5ba5255
Compare
threepointone
approved these changes
May 17, 2022
GregBrimble
approved these changes
May 17, 2022
jrf0110
force-pushed
the
1029-folders-periods
branch
from
5ba5255 to
6833987
Compare
…t assets publish Fixes cloudflare#1029 Our extension extraction logic was taking into account folder names, which can include periods. The logic would incorrectly identify a file path of `.well-known/foo` as having the extension of `well-known/foo` when in reality it should be an empty string.
jrf0110
force-pushed
the
1029-folders-periods
branch
from
6833987 to
0b536ee
Compare
Co-authored-by: Pete Bacon Darwin <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1029
Our extension extraction logic was taking into account folder names, which can include periods. The logic would incorrectly identify a file path of
.well-known/fooas having the extension ofwell-known/foowhen in reality it should be an empty string.