-
Notifications
You must be signed in to change notification settings - Fork 770
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: pages "command" can consist of multiple words (#1057)
On Windows, the following command `wrangler pages dev -- foo bar` would error saying that `bar` was not a known argument. This is because `foo` and `bar` are passed to Yargs as separate arguments. A workaround is to put the command in quotes: `wrangler pages dev -- "foo bar"`. But this fix makes the `command` argument variadic, which also solves the problem. Fixes [#965](#965)
- Loading branch information
1 parent
8eeef9a
commit 608dcd9
Showing
3 changed files
with
19 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
"wrangler": patch | ||
--- | ||
|
||
fix: pages "command" can consist of multiple words | ||
|
||
On Windows, the following command `wrangler pages dev -- foo bar` would error | ||
saying that `bar` was not a known argument. This is because `foo` and `bar` are | ||
passed to Yargs as separate arguments. | ||
|
||
A workaround is to put the command in quotes: `wrangler pages dev -- "foo bar"`. | ||
But this fix makes the `command` argument variadic, which also solves the problem. | ||
|
||
Fixes [#965](https://github.com/cloudflare/wrangler2/issues/965) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters