-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler pages publish #790
Merged
GregBrimble
merged 15 commits into
cloudflare:main
from
sidharthachatterjee:pages-publish
Apr 26, 2022
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ab092a4
wip
sidharthachatterjee b7f4d55
wip
sidharthachatterjee aab8d3c
wip
sidharthachatterjee 8a2c878
Ignore _worker.js, _redirects, _headers, .DS_Store
sidharthachatterjee b31cd6d
Merge branch 'main' into pages-publish
sidharthachatterjee 3af8c38
Update package-lock.json
sidharthachatterjee 63e65da
Add more TODO comments for future me
sidharthachatterjee 7937ae2
Ignore node_modules
sidharthachatterjee 24531d0
Ignore symlinks
sidharthachatterjee 079d399
Git stuff
sidharthachatterjee 0afdd00
Alias 'wrangler pages publish' with 'wrangler pages deployment create'
GregBrimble 1b73041
Merge remote-tracking branch 'origin/main' into pr/sidharthachatterje…
GregBrimble 5da43f0
Attach meta files
GregBrimble 0b32c13
Test 'pages deployment create'
GregBrimble 673c2a2
Add changeset for 'wrangler pages publish'
GregBrimble File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"wrangler": patch | ||
--- | ||
|
||
feature: Adds 'wrangler pages publish' (alias 'wrangler pages deployment create') command. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you tell me why we use
blake3-wasm
here, and notxxhash
which we already use for sites? If possible, I'd like to use xxhash everywhere, unless there's a reason I'm not aware of?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use Blake3 in Pages currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did come across a pure-JS implementation later on for something else, so we could swap that in, in place of the WASM, if you'd prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, so that hashes match what Pages already does internally. But since the projects published via API wouldn't be compared with "native" Pages projects, would the choice of hasher here matter? Just want to make sure we're intentional here with this choice, because changing later would invalidate all previous projects (if I'm understanding correctly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a possible future where you can upload to an existing project, so yeah, we need to be consistent with how files are hashed today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aight, that's a good reason.