Skip to content

feat (C3): Remove a bindings snippet for Hono template #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarmenPopoviciu merged 6 commits into from
Aug 15, 2024
Merged

feat (C3): Remove a bindings snippet for Hono template #6481

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac922ab
feat: [C3] Remove a snippet for hono
roottool Aug 13, 2024
39cb9cd
feat: [C3] Remove a snippet insertion
roottool Aug 13, 2024
49eb4e7
docs: Add changeset
roottool Aug 13, 2024
955b13f
Merge branch 'main' into feature/remove-binding-snippet-for-hono
roottool Aug 13, 2024
0dcb894
docs: Convert from `feat` to `fix`
roottool Aug 14, 2024
2e738eb
Merge branch 'main' into feature/remove-binding-snippet-for-hono
roottool Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaggy-poets-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-cloudflare": patch
---

feat: Update `hono` template to remove binding type snippet.
Comment thread
roottool marked this conversation as resolved.
Outdated
10 changes: 0 additions & 10 deletions packages/create-cloudflare/templates/hono/c3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,6 @@ const configure = async (ctx: C3Context) => {
const snippets = loadTemplateSnippets(ctx);

transformFile(indexFile, {
// Insert the env declaration after the last import (but before the rest of the body)
visitProgram: function (n) {
const lastImportIndex = n.node.body.findLastIndex(
(t) => t.type === "ImportDeclaration",
);
const lastImport = n.get("body", lastImportIndex);
lastImport.insertAfter(...snippets.bindingsTypeTs);

return this.traverse(n);
},
visitVariableDeclarator(n) {
if (n.node.id.type === "Identifier" && n.node.id.name === "app") {
n.node.init = snippets
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/templates/hono/snippets/appDeclaration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
new Hono<{ Bindings: Bindings }>()
new Hono<{ Bindings: CloudflareBindings }>()
3 changes: 0 additions & 3 deletions packages/create-cloudflare/templates/hono/snippets/bindingsType.ts
View file
Open in desktop

This file was deleted.