Skip to content

Remove Hyperdrive warning log indicating that Hyperdrive local binding does not work #5812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petebacondarwin merged 4 commits into from
May 20, 2024
Merged

Remove Hyperdrive warning log indicating that Hyperdrive local binding does not work #5812

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d854f9e
Remove Hyperdrive warning log indicating that Hyperdrive local bindin…
thomasgauvin May 13, 2024
5c98225
Add changeset
thomasgauvin May 13, 2024
a4dd4bc
Update .changeset/thirty-kings-serve.md
thomasgauvin May 13, 2024
d69ffaf
Nit changeset fix
thomasgauvin May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-kings-serve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Update Hyperdrive logs to reflect that hyperdrive bindings are now supported in local dev

@CarmenPopoviciu CarmenPopoviciu May 13, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the recommended changeset message format

@thomasgauvin thomasgauvin May 20, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarmenPopoviciu good to merge now?

6 changes: 0 additions & 6 deletions packages/wrangler/src/dev/dev.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,12 +433,6 @@ function DevSession(props: DevSessionProps) {
);
}

if (props.local && props.bindings.hyperdrive?.length) {
logger.warn(
"Hyperdrive does not currently support 'wrangler dev' in local mode at this stage of the beta. Use the '--remote' flag to test a Hyperdrive configuration before deploying."
);
}

const announceAndOnReady: typeof props.onReady = async (
finalIp,
finalPort,
Expand Down