-
Notifications
You must be signed in to change notification settings - Fork 1.4k
D1: execute --file --remote now uses dedicated import API #5696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1ab5f83
D1: Refactored to remove batching entirely
geelen 1056b47
Adds R2-based SQL import into remote D1 DBs
geelen 556f95f
D1 export: make --no-schema/--no-data work
geelen 12fc123
Extracted PollingFailure type
geelen 3d8dd6f
Fixing json mode for remote DB execution
geelen 575409f
Updates based on PR feedback
geelen a16f5fc
Updates based on PR feedback
geelen 9dae146
Added test to cover binary sqlite3 file check
geelen f6d8685
Added changeset
geelen 23fbf2f
Added spinners to the output during async operations
geelen 3b0c941
Linting
geelen cf78a40
Update changeset
RamIdeas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "wrangler": minor | ||
| --- | ||
|
|
||
| Improved `d1 execute --file --remote` performance & added support for much larger SQL files within a single transaction. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| export const DEFAULT_MIGRATION_PATH = "./migrations"; | ||
| export const DEFAULT_MIGRATION_TABLE = "d1_migrations"; | ||
| export const LOCATION_CHOICES = ["weur", "eeur", "apac", "oc", "wnam", "enam"]; | ||
| // Max number of statements to send in a single /execute call | ||
| export const DEFAULT_BATCH_SIZE = 10_000; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.