Skip to content

[C3] Skip empty summary rows #5483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petebacondarwin merged 4 commits into from
Apr 21, 2024
Merged

[C3] Skip empty summary rows #5483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cde707e
Skip empty summary rows
DaniFoldi Apr 2, 2024
d0d799b
Add changeset
DaniFoldi Apr 2, 2024
88c6f61
Replace fix as suggested
DaniFoldi Apr 4, 2024
200ae27
Update changeset per suggestion
DaniFoldi Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-cheetahs-attack.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-cloudflare": patch
---

fix: make sure that using the current directory doesn't generate an `undefined undefined` log in the output summary.
6 changes: 3 additions & 3 deletions packages/create-cloudflare/src/summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ export const printSummary = async (ctx: C3Context) => {

const dirRelativePath = relative(ctx.originalCWD, ctx.project.path);
const nextSteps = [
dirRelativePath
? ["Navigate to the new directory", `cd ${dirRelativePath}`]
: [],
...(dirRelativePath
? [["Navigate to the new directory", `cd ${dirRelativePath}`]]
: []),
[
"Run the development server",
quoteShellArgs([npm, "run", ctx.template.devScript ?? "start"]),
Expand Down