Skip to content

[pages] Add wrangler pages config download #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
penalosa merged 11 commits into from
Mar 25, 2024
Merged

[pages] Add wrangler pages config download #5327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3970fd3
Add specific error code
penalosa Mar 20, 2024
5278da5
Add location
penalosa Mar 21, 2024
4191958
Add argument
penalosa Mar 21, 2024
ac07261
Support basic config download
penalosa Mar 21, 2024
ad9fe1f
DO
penalosa Mar 21, 2024
5a09146
fix tests
penalosa Mar 22, 2024
8ef1a86
Add no-op build metadata arg
penalosa Mar 22, 2024
6bbb96c
Create little-baboons-reflect.md
penalosa Mar 22, 2024
2561cd1
Create fresh-comics-carry.md
penalosa Mar 22, 2024
3e27b06
Address review comments
penalosa Mar 22, 2024
b5deb07
Move download command
penalosa Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-comics-carry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

fix: Use specific error code to signal a wrangler.toml file not being found in build-env
5 changes: 5 additions & 0 deletions .changeset/little-baboons-reflect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": minor
---

feat: Add `wrangler pages download config`
10 changes: 5 additions & 5 deletions packages/wrangler/src/__tests__/pages/pages-build-env.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe("pages-build-env", () => {
pages_build_output_dir: "./dist",
vars: {},
});
await runWrangler("pages functions build-env");
await runWrangler("pages functions build-env .");
expect(std).toMatchInlineSnapshot(`
Object {
"debug": "",
Expand All @@ -32,7 +32,7 @@ describe("pages-build-env", () => {

it("should fail with no config file", async () => {
await expect(
runWrangler("pages functions build-env")
runWrangler("pages functions build-env .")
).rejects.toThrowErrorMatchingInlineSnapshot(
`"No Pages config file found"`
);
Expand Down Expand Up @@ -65,7 +65,7 @@ describe("pages-build-env", () => {
},
},
});
await runWrangler("pages functions build-env");
await runWrangler("pages functions build-env .");
expect(std).toMatchInlineSnapshot(`
Object {
"debug": "",
Expand Down Expand Up @@ -104,7 +104,7 @@ describe("pages-build-env", () => {
},
},
});
await runWrangler("pages functions build-env");
await runWrangler("pages functions build-env .");
expect(std).toMatchInlineSnapshot(`
Object {
"debug": "",
Expand Down Expand Up @@ -144,7 +144,7 @@ describe("pages-build-env", () => {
},
},
});
await runWrangler("pages functions build-env");
await runWrangler("pages functions build-env .");
expect(std).toMatchInlineSnapshot(`
Object {
"debug": "",
Expand Down
Loading