-
Notifications
You must be signed in to change notification settings - Fork 1.1k
expose cf object from Miniflare instances #4905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ef65e88
expose cf object from Miniflare instances
dario-piotrowicz 3a98cd4
add changeset
dario-piotrowicz 3d957f9
add tests for getCf
dario-piotrowicz 930248c
Apply suggestions from code review
dario-piotrowicz 2e7948b
remove second example from changeset
dario-piotrowicz 8c9607b
avoid importing fallbackCf from src in test file
dario-piotrowicz b9e4d3c
add missing dispose calls
dario-piotrowicz 64dccdc
prettify index.spec.ts file
dario-piotrowicz 4e99cd5
use teardown in order to dispose mf
dario-piotrowicz 276a385
add space between cf creation and checks
dario-piotrowicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| "miniflare": minor | ||
| --- | ||
|
|
||
| feature: add a `getCf` method to Miniflare instances | ||
|
|
||
| add a new `getCf` method attached to instances of `Miniflare`, this `getCf` returns | ||
| the `cf` object that the Miniflare instance provides to the actual workers and it | ||
| depends of the core option of the same name | ||
|
|
||
| Example: | ||
|
|
||
| ```ts | ||
| import { Miniflare } from "miniflare"; | ||
|
|
||
| const mf = new Miniflare({ ... }); | ||
|
|
||
| const cf = await mf.getCf(); | ||
|
|
||
| console.log(`country = ${cf.country} ; colo = ${cf.colo}`); // logs 'country = GB ; colo = LHR' | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.