Skip to content

Pack miniflare for e2e #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
penalosa merged 12 commits into from
Nov 16, 2023
Merged

Pack miniflare for e2e #4458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
30958d3
Pack miniflare for e2e
penalosa Nov 16, 2023
90e704e
Support windows
penalosa Nov 16, 2023
b777a53
windows?
penalosa Nov 16, 2023
abc637b
file protocol
penalosa Nov 16, 2023
2bf5472
verbose
penalosa Nov 16, 2023
2ac4cb9
more verbose
penalosa Nov 16, 2023
c410d68
add
penalosa Nov 16, 2023
399ae42
windows?
penalosa Nov 16, 2023
e62a5dd
windows 2?
penalosa Nov 16, 2023
1eb451b
windows 3
penalosa Nov 16, 2023
4869bc2
all tests
penalosa Nov 16, 2023
7124350
remove output
penalosa Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,17 @@ jobs:
NODE_ENV: "production"
CI_OS: ${{ runner.os }}

- name: Build Wrangler package for npm
- name: Pack Miniflare
run: pnpm pack --pack-destination $HOME
env:
NODE_ENV: "production"
working-directory: packages/miniflare

- name: Modify wrangler package.json miniflare dependency
run: pnpm add $(ls $HOME/miniflare-*.tgz)
working-directory: packages/wrangler

- name: Pack Wrangler
run: pnpm pack --pack-destination $HOME
env:
NODE_ENV: "production"
Expand All @@ -62,8 +72,6 @@ jobs:
shell: bash
id: "find-wrangler"
run: echo "dir=$(ls $HOME/wrangler-*.tgz)" >> $GITHUB_OUTPUT;
env:
NODE_ENV: "production"

- name: Run tests
id: e2e-1
Expand All @@ -74,12 +82,3 @@ jobs:
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.TEST_CLOUDFLARE_ACCOUNT_ID }}
WRANGLER: pnpm --silent --package ${{ steps.find-wrangler.outputs.dir}} dlx wrangler
NODE_OPTIONS: "--max_old_space_size=8192"

- name: Retry tests
if: steps.e2e-1.outcome == 'failure'
run: pnpm run --filter wrangler test:e2e
env:
CLOUDFLARE_API_TOKEN: ${{ secrets.TEST_CLOUDFLARE_API_TOKEN }}
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.TEST_CLOUDFLARE_ACCOUNT_ID }}
WRANGLER: pnpm --silent --package ${{ steps.find-wrangler.outputs.dir}} dlx wrangler
NODE_OPTIONS: "--max_old_space_size=8192"
2 changes: 1 addition & 1 deletion packages/wrangler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"test": "pnpm run assert-git-version && jest",
"test:ci": "pnpm run test --coverage",
"test:debug": "pnpm run test --silent=false --verbose=true",
"test:e2e": "vitest --test-timeout 240000 --single-thread --dir ./e2e run",
"test:e2e": "vitest --test-timeout 240000 --single-thread --dir ./e2e --retry 2 run",
"test:watch": "pnpm run test --runInBand --testTimeout=50000 --watch",
"type:tests": "tsc -p ./src/__tests__/tsconfig.json && tsc -p ./e2e/tsconfig.json"
},
Expand Down