Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass worker name to syncAssets in dev #333

Merged
merged 1 commit into from
Jan 29, 2022
Merged

fix: pass worker name to syncAssets in dev #333

merged 1 commit into from
Jan 29, 2022

Commits on Jan 28, 2022

  1. fix: pass worker name to syncAssets in dev 

    This fix passes the correct worker name to `syncAssets` during `wrangler dev`. This function uses the name to create the backing kv store for a Workers Sites definition, so it's important we get the name right.

I also fixed the lint warning introduced in #321, to pass `props.enableLocalPersistence` as a dependency in the `useEffect` call that starts the "local" mode dev server.
    @threepointone
    threepointone committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    95e279b View commit details
    Browse the repository at this point in the history