-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #313
Merged
Merged
Version Packages #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
changeset-release/main
branch
5 times, most recently
from
January 27, 2022 23:11
aef8cc4
to
4f0092b
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
January 28, 2022 11:33
4f0092b
to
7424d4c
Compare
This was referenced Nov 23, 2023
This was referenced Dec 1, 2023
This was referenced Dec 9, 2023
This was referenced Jan 9, 2024
This was referenced Jan 17, 2024
This was referenced Jan 25, 2024
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Patch Changes
#307
53c6318
Thanks @threepointone! - feat:wrangler secret * --local
This PR implements
wrangler secret
for--local
mode. The implementation is simply a no-op, since we don't want to actually write secret values to disk (I think?). I also got the messaging for remote mode right by copying from wrangler 1. Further, I added tests for all thewrangler secret
commands.#324
b816333
Thanks @GregBrimble! - Fixeswrangler pages dev
failing to start for just a folder of static assets (no functions)#317
d6ef61a
Thanks @threepointone! - fix: restart thedev
proxy server whenever it closesWhen we run
wrangler dev
, the session that we setup with the preview endpoint doesn't last forever, it dies after ignoring it for 5-15 minutes or so. The fix for this is to simply reconnect the server. So we use a state hook as a sigil, and add it to the dependency array of the effect that sets up the server, and simply change it every time the server closes.Fixes restart
dev
when session expires #197(In wrangler1, we used to restart the whole process, including uploading the worker again, making a new preview token, and so on. It looks like that they may not have been necessary.)
#312
77aa324
Thanks @threepointone! - fix: remove--prefer-offline
when runningnpm install
We were using
--prefer-offline
when runningnpm install
duringwrangler init
. The behaviour is odd, it doesn't seem to fetch from the remote when the cache isn't hit, which is not what I'm expecting. So we remove--prefer-offline
.#311
a5537f1
Thanks @threepointone! - fix: custom builds should allow multiple commandsWe were running custom builds as a regular command with
execa
. This would fail whenever we tried to run compound commands likecargo install -q worker-build && worker-build --release
(via Multiple commands in build.command fail on Linux #236). The fix is to useshell: true
, so that the command is run in a shell and can thus use bash-y syntax like&&
, and so on. I also switched to usingexecaCommand
which splits a command string into parts correctly by itself.#321
5b64a59
Thanks @geelen! - fix: disable local persistence by default & add--experimental-enable-local-persistence
flagBREAKING CHANGE:
When running
dev
locally any data stored in KV, Durable Objects or the cache are no longer persisted between sessions by default.To turn this back on add the
--experimental-enable-local-persistence
at the command line.