Skip to content

Fix potential memory leak in module runner #13087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesopstad merged 3 commits into from
Mar 27, 2026
Merged

Fix potential memory leak in module runner #13087

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1f9c74
Clean up module runner callbacks on errors
jamesopstad Mar 27, 2026
70a08bb
Add changeset
jamesopstad Mar 27, 2026
2f10f6e
Remove changeset
jamesopstad Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/loose-humans-join.md
View file
Open in desktop
Comment thread
petebacondarwin marked this conversation as resolved.
Outdated
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudflare/vite-plugin": patch
---

Fix potential memory leak in module runner
15 changes: 8 additions & 7 deletions packages/vite-plugin-cloudflare/src/workers/runner-worker/module-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,15 @@ async function runInRunnerObject(
const id = nextCallbackId++;
pendingCallbacks.set(id, callback);

const stub = env.__VITE_RUNNER_OBJECT__.get("singleton");
await stub.executeCallback(id);
try {
const stub = env.__VITE_RUNNER_OBJECT__.get("singleton");
await stub.executeCallback(id);

const result = callbackResults.get(id);
callbackResults.delete(id);

return result;
return callbackResults.get(id);
} finally {
pendingCallbacks.delete(id);
callbackResults.delete(id);
}
}

/**
Expand Down Expand Up @@ -152,7 +154,6 @@ export class __VITE_RUNNER_OBJECT__ extends DurableObject<WrapperEnv> {
*/
async executeCallback(id: number): Promise<void> {
const callback = pendingCallbacks.get(id);
pendingCallbacks.delete(id);

if (!callback) {
throw new Error(`No pending callback with id ${id}`);
Expand Down
Loading