Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that the proxy server shuts down to prevent wrangler dev from hanging #1088

Merged
merged 3 commits into from
May 23, 2022
Merged

fix: ensure that the proxy server shuts down to prevent wrangler dev from hanging #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34fd103
refactor: add abort signal support to creating worker previews
petebacondarwin May 20, 2022
4bf0848
refactor: add typings for `AbortSignal#abort` event
petebacondarwin May 23, 2022
2dfb45e
fix: ensure that the proxy server shuts down to prevent `wrangler dev…
petebacondarwin May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/nasty-cobras-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"wrangler": patch
---

fix: ensure that the proxy server shuts down to prevent `wrangler dev` from hanging

When running `wrangler dev` we create a proxy to the actual remote Worker.
After creating a connection to this proxy by a browser request the proxy did not shutdown.
Now we use a `HttpTerminator` helper library to force the proxy to close open connections and shutdown correctly.

Fixes #958
Loading