Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: wrangler dev still sometimes fails to exit cleanly after Ctl-C #958

Closed
petebacondarwin opened this issue May 10, 2022 · 3 comments · Fixed by #1088 or #1078
Closed

🐛 BUG: wrangler dev still sometimes fails to exit cleanly after Ctl-C #958

petebacondarwin opened this issue May 10, 2022 · 3 comments · Fixed by #1088 or #1078
Assignees
@petebacondarwin
Labels
bug Something that isn't working

Comments

@petebacondarwin
Copy link
Contributor

What version of Wrangler are you using?

2.0.2

What operating system are you using?

Mac

Describe the Bug

Occasionally, hitting Ctrl-C when running wrangler dev does not result in the process exiting. Instead it just hangs.
Previously we had this problem but thought we had fixed it with #732. But it seems to have reappeared.
@petebacondarwin
Copy link
Contributor Author

cc @d3lm

@JacobMGEvans
Copy link
Contributor

Oh no, how often does it still happen?

@petebacondarwin
Copy link
Contributor Author

I think it only happens if you have made a request to the Worker and there is a connection being held open somewhere.

@petebacondarwin petebacondarwin moved this to Must-have in workers-sdk May 12, 2022
@petebacondarwin petebacondarwin modified the milestones: 2.1, Selected for development, Backlog May 12, 2022
@petebacondarwin petebacondarwin moved this to Backlog in workers-sdk May 15, 2022
@petebacondarwin petebacondarwin removed this from the Backlog milestone May 15, 2022
@petebacondarwin petebacondarwin added bug Something that isn't working and removed type: bug labels May 16, 2022
@petebacondarwin petebacondarwin moved this from Backlog to Selected for development in workers-sdk May 16, 2022
@petebacondarwin petebacondarwin self-assigned this May 18, 2022
@petebacondarwin petebacondarwin moved this from Selected for development to In Progress in workers-sdk May 21, 2022
petebacondarwin added a commit to petebacondarwin/wrangler2 that referenced this issue May 23, 2022
@petebacondarwin
fix: ensure that the proxy server shuts down to prevent `wrangler dev…
2dfb45e 
…` from hanging

When running `wrangler dev` we create a proxy to the actual remote Worker.
After creating a connection to this proxy by a browser request the proxy did not shutdown.
Now we use a `HttpTerminator` helper library to force the proxy to close open connections and shutdown correctly.

Fixes cloudflare#958
@petebacondarwin petebacondarwin mentioned this issue May 23, 2022
Merged
@petebacondarwin petebacondarwin moved this from In Progress to In Review in workers-sdk May 23, 2022
petebacondarwin added a commit that referenced this issue May 23, 2022
@petebacondarwin
fix: ensure that the proxy server shuts down to prevent `wrangler dev…
d63d790 
…` from hanging (#1088)

* refactor: add abort signal support to creating worker previews

* refactor: add typings for `AbortSignal#abort` event

* fix: ensure that the proxy server shuts down to prevent `wrangler dev` from hanging

When running `wrangler dev` we create a proxy to the actual remote Worker.
After creating a connection to this proxy by a browser request the proxy did not shutdown.
Now we use a `HttpTerminator` helper library to force the proxy to close open connections and shutdown correctly.

Fixes #958
Repository owner moved this from In Review to Done in workers-sdk May 23, 2022
@github-actions github-actions bot mentioned this issue May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petebacondarwin petebacondarwin

Labels
bug Something that isn't working
Projects
None yet
Milestone
No milestone
2 participants
@petebacondarwin @JacobMGEvans