🐛 BUG: --experimental-enable-local-persistence stores KV, Durable Objects and Cache data in the same directory

[mrbbot]

What version of Wrangler are you using?

0.0.26-ee3475f

What operating system are you using?

Mac

Describe the Bug

Wrangler 2 sets Miniflare's kvPersist, durableObjectsPersist and cachePersist options to the same string path value when --experimental-enable-local-persistence is enabled:
https://github.com/cloudflare/wrangler2/blob/9d04a6866099e77a93a50dfd33d6e7707e4d9e9c/packages/wrangler/src/dev/local.tsx#L175-L182
This means KV namespaces, Durable Objects, or caches using the same name will share data.

---

As an example, consider the following worker:

// index.js
export default {
  async fetch(request, env, ctx) {
    const cache = await caches.open("test");
    await cache.put(
      "http://localhost",
      new Response("body", { headers: { "Cache-Control": "max-age=3600" } })
    );
    const { keys } = await env.test.list();
    return new Response(JSON.stringify(keys));
  },
};

# wrangler.toml
main = "index.js"
compatibility_date = "2022-04-21"
kv_namespaces = [
    { binding = "test", id = "_", preview_id = "__" }
]

This returns the following response, even though no data was written to the test KV namespace:

[{"name":"http://localhost/","expiration":1650553706,"metadata":{"status":200,"headers":[["cache-control","max-age=3600"],["content-type","text/plain;charset=UTF-8"]]}}]

Running tree shows the problem here:

$ tree
.
├── index.js
├── wrangler-local-state
│   └── test
│       └── http
│           ├── localhost_
│           └── localhost_.meta.json
└── wrangler.toml

The test directory is being shared by the KV namespace and the cache.

---

A solution here is to put KV namespaces, Durable Objects and caches in their own subdirectories, by adding a unique path segment to the end of localPersistencePathOrDisableLocalPersistence for each of kvPersist, durableObjectsPersist and cachePersist.

[threepointone]

good catch! we'll fix this. thank you for reporting!