Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: routes should be able to specify zone_name #793

Closed
threepointone opened this issue Apr 13, 2022 · 0 comments · Fixed by #797 or #780
Closed

feat: routes should be able to specify zone_name #793

threepointone opened this issue Apr 13, 2022 · 0 comments · Fixed by #797 or #780

Comments

@threepointone
Copy link
Contributor

A follow up on #774, we should also be able to optionally send zone_name with routes. I'm not sure what zone_name actually is (a domain?), but I assume the api should be similar to how zone_id is passed.
@threepointone threepointone moved this to Must-have in workers-sdk Apr 13, 2022
@threepointone threepointone added this to the 2.0 milestone Apr 13, 2022
threepointone added a commit that referenced this issue Apr 14, 2022
@threepointone
feat: optionally send zone_name with routes
aae03f0 
A followup to #778, this lets you send an optional `zone_name` with routes. This is particularly useful when using ssl for saas (https://developers.cloudflare.com/ssl/ssl-for-saas/).

Fixes #793
@threepointone threepointone mentioned this issue Apr 14, 2022
Merged
threepointone added a commit that referenced this issue Apr 14, 2022
@threepointone
feat: optionally send zone_name with routes
8f5105e 
A followup to #778, this lets you send an optional `zone_name` with routes. This is particularly useful when using ssl for saas (https://developers.cloudflare.com/ssl/ssl-for-saas/).

Fixes #793
@petebacondarwin petebacondarwin moved this from Must-have to In Review in workers-sdk Apr 14, 2022
threepointone added a commit that referenced this issue Apr 15, 2022
@threepointone
feat: optionally send zone_name with routes
709e07f 
A followup to #778, this lets you send an optional `zone_name` with routes. This is particularly useful when using ssl for saas (https://developers.cloudflare.com/ssl/ssl-for-saas/).

Fixes #793
threepointone added a commit that referenced this issue Apr 15, 2022
@threepointone
feat: optionally send zone_name with routes
ae62a5f 
A followup to #778, this lets you send an optional `zone_name` with routes. This is particularly useful when using ssl for saas (https://developers.cloudflare.com/ssl/ssl-for-saas/).

Fixes #793
threepointone added a commit that referenced this issue Apr 15, 2022
@threepointone
feat: optionally send zone_name with routes (#797)
67fc4fc 
A followup to #778, this lets you send an optional `zone_name` with routes. This is particularly useful when using ssl for saas (https://developers.cloudflare.com/ssl/ssl-for-saas/).

Fixes #793
Repository owner moved this from In Review to Done in workers-sdk Apr 15, 2022
@github-actions github-actions bot mentioned this issue Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@threepointone