-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local-mode-tests
blows up the CI logs with waiting for connection...
on windows
#776
Labels
maintenance
Maintenance task
Comments
Can this be closed? Looks like it doesn't cause that spam anymore? |
Closing. Please re-open @caass if it is still a problem. |
This is still happening, reopening. It's not related to the webpack stuff since we disabled those tests. |
assigning to myself. might just disable those tests on windows. |
threepointone
added a commit
that referenced
this issue
Apr 25, 2022
Something about the local mode tests makes it occasionally break in windows on CI. Specifically, the inspector fails to connect to the miniflare process, and ends up spamming "waiting for connection" in the logs. I'm disabling these tests since they're for sanity only right now, and we have a fuller suite of tests for windows in the main package anyway. Fixes #776
threepointone
added a commit
that referenced
this issue
Apr 25, 2022
Something about the local mode tests makes it occasionally break in windows on CI. Specifically, the inspector fails to connect to the miniflare process, and ends up spamming "waiting for connection" in the logs. I'm disabling these tests since they're for sanity only right now, and we have a fuller suite of tests for windows in the main package anyway. Fixes #776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here's an example.
This makes it really annoying to debug CI failures since you have to scroll through, no exaggeration, seventeen thousand lines of
waiting for connection...
.This might have to do with my own tests (#759) not exiting properly, so if it gets fixed when i patch my stuff i'll close this
The text was updated successfully, but these errors were encountered: