Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local-mode-tests blows up the CI logs with waiting for connection... on windows #776

Closed
caass opened this issue Apr 9, 2022 · 4 comments · Fixed by #841
Closed

local-mode-tests blows up the CI logs with waiting for connection... on windows #776

caass opened this issue Apr 9, 2022 · 4 comments · Fixed by #841
Labels
maintenance Maintenance task

Comments

@caass
Copy link
Contributor

caass commented Apr 9, 2022

Here's an example.

This makes it really annoying to debug CI failures since you have to scroll through, no exaggeration, seventeen thousand lines of waiting for connection....

This might have to do with my own tests (#759) not exiting properly, so if it gets fixed when i patch my stuff i'll close this

@caass caass added the maintenance Maintenance task label Apr 9, 2022
@threepointone
Copy link
Contributor

Can this be closed? Looks like it doesn't cause that spam anymore?

@petebacondarwin
Copy link
Contributor

Closing. Please re-open @caass if it is still a problem.

@threepointone
Copy link
Contributor

This is still happening, reopening. It's not related to the webpack stuff since we disabled those tests.

@threepointone threepointone reopened this Apr 25, 2022
@threepointone
Copy link
Contributor

assigning to myself. might just disable those tests on windows.

threepointone added a commit that referenced this issue Apr 25, 2022
Something about the local mode tests makes it occasionally break in windows on CI. Specifically, the inspector fails to connect to the miniflare process, and ends up spamming "waiting for connection" in the logs. I'm disabling these tests since they're for sanity only right now, and we have a fuller suite of tests for windows in the main package anyway.

Fixes #776
threepointone added a commit that referenced this issue Apr 25, 2022
Something about the local mode tests makes it occasionally break in windows on CI. Specifically, the inspector fails to connect to the miniflare process, and ends up spamming "waiting for connection" in the logs. I'm disabling these tests since they're for sanity only right now, and we have a fuller suite of tests for windows in the main package anyway.

Fixes #776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants