Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with wrangler dev, warn if wrangler.toml doesn't have a compatibility_date #741

Closed
threepointone opened this issue Mar 31, 2022 · 0 comments · Fixed by #752 or #721
Closed

with wrangler dev, warn if wrangler.toml doesn't have a compatibility_date #741

threepointone opened this issue Mar 31, 2022 · 0 comments · Fixed by #752 or #721
Assignees
@petebacondarwin

Comments

@threepointone
Copy link
Contributor

This is the parallel to wrangler publish where we error if a compatibility_date isn't passed. We shouldn't warn if there isn't a wrangler.toml file at all.
@threepointone threepointone added this to the 2.0 milestone Mar 31, 2022
@threepointone threepointone moved this to Should-have in workers-sdk Mar 31, 2022
@petebacondarwin petebacondarwin self-assigned this Apr 2, 2022
petebacondarwin added a commit to petebacondarwin/wrangler2 that referenced this issue Apr 3, 2022
@petebacondarwin
fix: add a warning if dev is defaulting to the latest compatibility…
a809fbd 
…-date

Fixes cloudflare#741
@petebacondarwin petebacondarwin moved this from Should-have to In Review in workers-sdk Apr 3, 2022
@petebacondarwin petebacondarwin mentioned this issue Apr 3, 2022
Merged
petebacondarwin added a commit to petebacondarwin/wrangler2 that referenced this issue Apr 4, 2022
@petebacondarwin
fix: add a warning if dev is defaulting to the latest compatibility…
9e13b21 
…-date

Fixes cloudflare#741
petebacondarwin added a commit that referenced this issue Apr 4, 2022
@petebacondarwin
fix: add a warning if dev is defaulting to the latest compatibility…
6d43e94 
…-date (#752)

Fixes #741
Repository owner moved this from In Review to Done in workers-sdk Apr 4, 2022
@github-actions github-actions bot mentioned this issue Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petebacondarwin petebacondarwin

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@petebacondarwin @threepointone