Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build/rebuild behaviour #731

Closed
threepointone opened this issue Mar 30, 2022 · 2 comments
Closed

fix: build/rebuild behaviour #731

threepointone opened this issue Mar 30, 2022 · 2 comments
Assignees
@threepointone

Comments

@threepointone
Copy link
Contributor

Noticed these today -

  • If we have an error in code when starting wrangler dev, then we don't restart the build process after fixing the code
  • error checking in bundleWorker() happens only on first run, but not on rebuilds (to check whether a worker exports the defined durable object classes, landing in fix: only send durable object migrations when required #728)
@threepointone threepointone added this to the 2.0 milestone Mar 30, 2022
@threepointone threepointone moved this to Must-have in workers-sdk Mar 30, 2022
@threepointone threepointone self-assigned this Mar 30, 2022
@threepointone threepointone mentioned this issue Mar 30, 2022
Merged
@threepointone threepointone moved this from Must-have to Should-have in workers-sdk Mar 30, 2022
@threepointone
Copy link
Contributor Author

Related: evanw/esbuild#1037

Maybe the thing to do here as a workaround for now is to end the process if it fails on first build.

threepointone added a commit that referenced this issue Mar 31, 2022
@threepointone
fix: exit dev if build fails on first run
8102d0b 
Because of evanw/esbuild#1037, we can't recover dev if esbuild fails on first run. The workaround is to end the process if it does so, until we have a better fix.

Reported in #731
@threepointone threepointone mentioned this issue Mar 31, 2022
Merged
@threepointone
Copy link
Contributor Author

threepointone commented Mar 31, 2022 •
edited
Loading

I removed the exports validation from #728, and sent a PR to exit the process on first failure in #734. Landing those two, and we can close this issue.

threepointone added a commit that referenced this issue Mar 31, 2022
@threepointone
fix: exit dev if build fails on first run (#734)
a1dadac 
Because of evanw/esbuild#1037, we can't recover dev if esbuild fails on first run. The workaround is to end the process if it does so, until we have a better fix.

Reported in #731
Repository owner moved this from Should-have to Done in workers-sdk Mar 31, 2022
@github-actions github-actions bot mentioned this issue Mar 31, 2022
Merged
mrbbot pushed a commit that referenced this issue Nov 1, 2023
@RamIdeas @mrbbot
bump patch version (#731)
435fa1c 
v3.20231025.1
mrbbot pushed a commit that referenced this issue Nov 1, 2023
@RamIdeas @mrbbot
bump patch version (#731)
300c30c 
v3.20231025.1
mrbbot pushed a commit that referenced this issue Nov 1, 2023
@RamIdeas @mrbbot
bump patch version (#731)
461c9aa 
v3.20231025.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@threepointone threepointone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@threepointone