🐛 BUG: Legacy Env name computed on publish

[JacobMGEvans]

What version of Wrangler are you using?

0.0.22

What operating system are you using?

Mac

Describe the Bug

Legacy environment mode should not compute name fields in environments.
result: name = my-worker-staging => publishes as my-worker-staging-staging

[threepointone]

Not sure I understand exactly. Could you show what wrangler.toml looks like, and what command you run?

[JacobMGEvans]

Not sure I understand exactly. Could you show what wrangler.toml looks like, and what command you run?

command: Publish
TOML:

name = "my-worker"
[[ env.staging ]]
name = "my-worker-staging"

The published Worker for staging will be called my-worker-staging-staging to parity Wrangler1 in legacy environment mode it should not compute the name fields in environments

[threepointone]

Ah ok I see. Yeah, if an environment has an explicit name, then we shouldn't add an environment identifier to it.

[petebacondarwin]

Capturing from offline discussion:

There is a weird case if the user provides the --name command line argument along with --env when dealing with legacy environments.

It is not 100% clear what should be the correct behaviour. Note that Wrangler 1 does not support the --name option.

We have decided, initially, to disallow this combination - --name + --env + legacy_env - for publishing. Providing a suitable error message that describes how to set the name in the environment section of the wrangler.toml if they wish to specify a name for a particular environment.

[threepointone]

We have decided, initially, to disallow this combination - --name + --env + legacy_env - for publishing.

+1. I assume this would be an extremely rare combo anyway.